fix: flickering of inactive collaborator #4053
Open
+624
−64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Better implements
active|away. also deals with when they switch from the tab and back.lastSeen.What was causing the flickering?
setIntervalwhich updates the user'slastSeenevery 10s, just so we are in the 30s intervalsetIntervalstart to miss their interval calls. eg. a 10s interval call might be actually triggered after 60s.Approach taken
lastStatecontrolled by the browser visibility API to track whether a user isactiveorawayHow do we smoothing the presence of a user to avoid the flickering?
away. (throttling likely happens to away users)Closes #3931
Validation steps
Additional notes for the reviewer
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)